-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't attempt to merge mustonlyhave
list
#165
Don't attempt to merge mustonlyhave
list
#165
Conversation
Re-running the workflows resulted in the tests passing. 🤷♂️ Here were the original failures for reference:
|
59d32f2
to
3ce84b5
Compare
3ce84b5
to
c79441d
Compare
ref: https://issues.redhat.com/browse/ACM-7799 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Using `reflect.deepEqual()` is unnecessary Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
c79441d
to
250a70c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8931b33
into
open-cluster-management-io:main
Most objects have lists that are nested, so the
compareLists()
function was never called (since when it's nestedmergeArrays()
is ultimately called). However, in the case of Openshift Template objects, it has an un-nested list, which called the buggy code. To illustrate, this looks like:Rather than:
ref: https://issues.redhat.com/browse/ACM-7799