Fix items in nested lists not always being matched #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a policy is looking for a field in a list, which is itself nested in an object in a list, and when there are multiple items in these lists on the cluster, the controller was not always matching things correctly. This could result in the policy's compliance depending on the order of the items in the nested list on the cluster. (The new test case may be more clear than this problem description.) This situation is difficult to reproduce: because of the way some lists were compared before, fields that don't seem like they should affect the result can change the outcome. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 32421e8
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a policy is looking for a field in a list, which is itself nested in an object in a list, and when there are multiple items in these lists on the cluster, the controller was not always matching things correctly. This could result in the policy's compliance depending on the order of the items in the nested list on the cluster. (The new test case may be more clear than this problem description.)
This situation is difficult to reproduce: because of the way some lists were compared before, fields that don't seem like they should affect the result can change the outcome.