Require objectDefinition and remediationAction
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could alternatively set a default for |
|
/hold for review (and a Jira, if reviews are positive) |
JustinKuli
approved these changes
Dec 5, 2023
mprahl
approved these changes
Dec 5, 2023
Without these fields, the policy is meaningless. When they're optional, a ConfigurationPolicy can be created without an `objectDefinition`. It'd be a better experience to make these required and surface the error sooner. ref: https://issues.redhat.com/browse/ACM-8898 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
require-objdef
branch
from
1b1b4d3
to
6f5b883
Compare
|
/unhold |
mprahl
approved these changes
Dec 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2476d97
into
open-cluster-management-io:main
4 checks passed
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these fields, the policy is meaningless. When they're optional, a ConfigurationPolicy can be created without an
objectDefinitionand, if there was an attempt to put the object at theobjectDefinitionlevel (i.e. apiVersion, kind, metadata), all those fields get wiped out without notice for the user. It'd be a better experience to make these required and surface the error sooner.I tested it out, and the status is returned properly: