Stop getting the K8s version of target cluster in uninstall mode #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JustinKuli , I'm going to manually test this situation. |
mprahl
force-pushed
the
uninstall-cluster-down3
branch
from
d613c41
to
94a3769
Compare
|
/hold for manual testing |
The target Kubernetes cluster may not be up and running at the time of uninstall, so don't bother getting cluster version information. This also stops nsSelMgr.Start from being called when being uninstalled. Relates: https://issues.redhat.com/browse/ACM-8826 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
uninstall-cluster-down3
branch
from
94a3769
to
430a93b
Compare
|
/unhold |
JustinKuli
approved these changes
Dec 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 56e2e70
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target Kubernetes cluster may not be up and running at the time of uninstall, so don't bother getting cluster version information.
Relates:
https://issues.redhat.com/browse/ACM-8826