Implement OperatorPolicy health checks for CSV #196
Conversation
JeffeyL
force-pushed
the
ACM-6598
branch
7 times, most recently
from
badaf01
to
ceb7b63
Compare
| @@ -17,7 +17,7 @@ var _ = Describe("Test installing an operator from OperatorPolicy", Ordered, fun | |||
| opPolTestNS = "operator-policy-testns" | |||
| parentPolicyYAML = "../resources/case38_operator_install/parent-policy.yaml" | |||
| parentPolicyName = "parent-policy" | |||
| opPolTimeout = 10 | |||
| opPolTimeout = 60 | |||
There was a problem hiding this comment.
👀 what's taking up to 60 seconds? I'd rather we adjust it for that specific test somehow. Maybe a separate Eventually for whatever that test is waiting a while for, before the main check.
It looks like this is only (currently) used in Eventually kinds of checks, so keeping this change wouldn't be the end of the world.
There was a problem hiding this comment.
I forget the exact one, but I will check.
Following the 'handle*' function pattern that is used by the subscription and operatorgroup checks, similar functionality was added to handle OLM CSVs. Modifications were made to the original subscription handle function in order to return the unstructured subscription object to make checking CSVs easier. Ref: https://issues.redhat.com/browse/ACM-9284 Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
There was a problem hiding this comment.
Looking good! It would be nice to have additional test cases for some of the other possible conditions. I know it's difficult to find an operator that will definitely not just work... In one of my OpenShift experiments I found that a subscription like this:
spec:
channel: singlenamespace-alpha
installPlanApproval: Manual
name: etcd
source: community-operators
sourceNamespace: openshift-marketplace
startingCSV: etcdoperator.v0.9.0has some problems - have you tried that?
If we really can't find a "broken" situation to test, that's ok for now. Eventually I think we'll need to create our own fake operator that we package so that we can test out odd upgrade situations, including when the deployment is broken, or the CSV gets into a weird status.
|
Still working on the additional test cases, will update here when done. |
JeffeyL
force-pushed
the
ACM-6598
branch
2 times, most recently
from
c09bf61
to
6fd4d1e
Compare
JeffeyL
force-pushed
the
ACM-6598
branch
7 times, most recently
from
d91bd99
to
7018699
Compare
Following the 'handle*' function pattern that is used by the subscription and operatorgroup checks, similar functionality was added to handle Deployments. Ref: https://issues.redhat.com/browse/ACM-6598 Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffeyL, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit eed59bc
into
open-cluster-management-io:main
This change follows the previous pattern of using
handlefunctions in order to handle different resources, in this case for ClusterServiceVersions (CSVs). ThehandleSubscriptionfunction was modified in order to return the unstructured subscription to make accessing CSV metadata easier. Since CSVs are managed by OLM, the controller reports conditions directly from the CSV in order to monitor its health. Changes also include updatingrelatedObjectsaccordingly.