Include the compliance history database IDs in compliance events #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
force-pushed
the
compliance-history-ids
branch
from
7f87127
to
e65b6f9
Compare
|
Thanks for the suggestion @yiraeChristineKim ! It's ready for review again. |
dhaiducek
requested changes
Feb 9, 2024
If the database IDs are set on the ConfigurationPolicy/OperatorPolicy, forward them along in the compliance event for the status-sync controller to record in the compliance events history API. Relates: https://issues.redhat.com/browse/ACM-6889 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
compliance-history-ids
branch
from
e65b6f9
to
c3f7d83
Compare
|
This is ready for review again! |
dhaiducek
approved these changes
Feb 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f6be8e7
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the database IDs are set on the ConfigurationPolicy/OperatorPolicy, forward them along in the compliance event for the status-sync controller to record in the compliance events history API.
Relates:
https://issues.redhat.com/browse/ACM-6889
Depends on open-cluster-management-io/governance-policy-framework-addon#111 to do anything.