Reduce debug logs for operatorpolicy test #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a quick comparison, I see only 8k lines in the E2E tests here, compared to https://github.com/open-cluster-management-io/config-policy-controller/actions/runs/7993535507/job/21829566080 where I see 76k lines. |
Instead of printing the log every time the function fails in one of the Eventually runs, it saves a message and will only print it if the test overall fails. This should reduce noise during the tests. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
less-test-debugging
branch
from
4ebb85c
to
520deac
Compare
mprahl
approved these changes
Feb 28, 2024
dhaiducek
approved these changes
Feb 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0671703
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing the log every time the function fails in one of the Eventually runs, it saves a message and will only print it if the test overall fails. This should reduce noise during the tests.