Adjust polarity of condition when CSV not found #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations where a subscription does not reference a CSV, a special condition is created and an event emitted to report that no relevant CSV was found. Previously, this condition was "True", which made sense with its reason, but not with the "ClusterServiceVersionCompliant" type. Now the condition will be "False", and the reason has been changed to still make sense. Refs: - https://issues.redhat.com/browse/ACM-10190 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
mprahl
approved these changes
Feb 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5b47b3a
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where a subscription does not reference a CSV, a special condition is created and an event emitted to report that no relevant CSV was found. Previously, this condition was "True", which made sense with its reason, but not with the "ClusterServiceVersionCompliant" type. Now the condition will be "False", and the reason has been changed to still make sense.
Refs: