Change unnamed related object from * to - #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiraeChristineKim
force-pushed
the
ACM-8782
branch
from
1a68543
to
9002d12
Compare
JustinKuli
previously approved these changes
Feb 29, 2024
Since we just want one thing to possibly match, using "*" makes it seem like all of the things are bad. Using "-" also matches what we do for some things when we don’t know/care about the namespace Ref: https://issues.redhat.com/browse/ACM-8782 Signed-off-by: Yi Rae Kim <yikim@redhat.com>
yiraeChristineKim
force-pushed
the
ACM-8782
branch
from
9002d12
to
dccf0d3
Compare
JustinKuli
approved these changes
Mar 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e64cb46
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derek was noticing the * named resources in OperatorPolicy when none of the ClusterServiceVersions match what we’re looking for … it is kind of a similar situation to https://issues.redhat.com/browse/ACM-8782, where we don’t know the name of the thing we want to put in the related resources section.
Since we just want one thing to possibly match, using "*" makes it seem like all of the things are bad. Using "-" also matches what we do for some things when we don’t know/care about the namespace
Ref: https://issues.redhat.com/browse/ACM-8782
Related: #182