Filter out unrelated subscription resolution failures #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold to make the regex more precise |
JustinKuli
reviewed
Mar 1, 2024
| // - no operators found in package %s in the catalog referenced by subscription %s | ||
| // - no operators found in channel %s of package %s in the catalog referenced by subscription %s | ||
| // - no operators found with name %s in channel %s of package %s in the catalog referenced by subscription %s | ||
| func isApplicableConstraintsNotSatisfiable(subscriptionName, packageName, message string) (bool, error) { |
There was a problem hiding this comment.
This function name is quite a mouthful. I would suggest are instead of is, to match the Constraints since that is plural, but that doesn't really make it feel better. What about something like messageIncludesSubscription?
|
/unhold |
JustinKuli
previously approved these changes
Mar 1, 2024
Since OLM includes a subscription error on all subscriptions in the namespace, even if that subscription itself is unaffected, operator policy needs to know if the error is related to the subscription. This adds some regex filtering to parse the messages since the message format is consistent. Relates: https://issues.redhat.com/browse/ACM-10195 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
JustinKuli
approved these changes
Mar 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit afef83e
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OLM includes a subscription error on all subscriptions in the namespace, even if that subscription itself is unaffected, operator policy needs to know if the error is related to the subscription. This adds some regex filtering to parse the messages since the message format is consistent.
Relates:
https://issues.redhat.com/browse/ACM-10195