Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRD descriptions #218

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Update CRD descriptions #218

merged 1 commit into from
Jun 6, 2024

Conversation

dhaiducek
Copy link
Member

ref: https://issues.redhat.com/browse/ACM-8992

Along with the description updates, I found some unused structs in the _type.go file that I've removed and one that was unused but in the CRD, so I marked it as unused/deprecated.

@dhaiducek dhaiducek marked this pull request as ready for review March 20, 2024 15:12
@dhaiducek
Copy link
Member Author

/hold for reviews

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2024
@yiraeChristineKim
Copy link
Contributor

Wow a lot of work Great Dale

mprahl
mprahl reviewed Apr 3, 2024
View reviewed changes
api/v1/configurationpolicy_types.go Outdated
// have Go templates. For more advanced Go templating such as `range` loops and `if` conditionals, use
// 'object-templates-raw'. Only one of 'object-templates' and 'object-templates-raw' may be set in a configuration
// policy.
// For more on the Go templates, see https://github.com/stolostron/go-template-utils/blob/main/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this link in upstream but I'm thinking we probably want to avoid it in the ACM version (i.e. Stolostron).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. For stolostron, we could have a doc link instead (though I'm not a huge fan of keeping up with the version there).

@openshift-ci openshift-ci bot removed the lgtm label Apr 3, 2024
@dockerymick
Copy link
Member

I thought I didn't review policy.open-cluster-management.io_configurationpolicies.yaml, but i did. i'm not sure why there is a conflict though

@dhaiducek
Copy link
Member Author

I thought I didn't review policy.open-cluster-management.io_configurationpolicies.yaml, but i did. i'm not sure why there is a conflict though

Sorry, I'm not following--what conflict are you referring to?
(I did get sidetracked and hadn't gotten to all of the comments yet.)

@dhaiducek dhaiducek force-pushed the 8992-crd-descriptions branch 2 times, most recently from c72ecb7 to 131c3d0 Compare May 16, 2024 14:14
@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
@dhaiducek
Copy link
Member Author

/unhold

@dhaiducek
Update CRD descriptions
b0a712f 
ref: https://issues.redhat.com/browse/ACM-8992
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 5, 2024
@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, dockerymick, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7215454 into open-cluster-management-io:main Jun 6, 2024
9 checks passed
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request Jun 6, 2024
Merged
@dhaiducek dhaiducek mentioned this pull request Jun 6, 2024
Merged
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request Jun 6, 2024
Closed
@dhaiducek dhaiducek deleted the 8992-crd-descriptions branch June 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprahl mprahl mprahl approved these changes

@dockerymick dockerymick dockerymick approved these changes

@yiraeChristineKim yiraeChristineKim yiraeChristineKim left review comments

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@mprahl mprahl

@dockerymick dockerymick

@yiraeChristineKim yiraeChristineKim

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhaiducek @yiraeChristineKim @dockerymick @mprahl @openshift-merge-robot