Fix constraints not satisfiable message causing compliance flood #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffeyL
force-pushed
the
ACM-10204
branch
3 times, most recently
from
6510503
to
0e74faf
Compare
JustinKuli
reviewed
Mar 26, 2024
JustinKuli
previously approved these changes
Mar 26, 2024
| } | ||
| } | ||
|
|
||
| if policyMessage == "" || !strings.Contains(cond.Message, cnfPrefix) { |
|
Some tests might be flaky after this change... I'll check it out |
ConstraintsNotSatisfiable message types in the subscription status are formatted "constraints not satisfiable: clause1, clause2, clause3 ...". However, the order of the clauses is nondeterministic, which causes compliance event flapping as each update leads to a different ordering of messages, which in turn triggers another update. This was fixed by sorting the message prior to evaluation. Ref: https://issues.redhat.com/browse/ACM-10204 Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
|
Turns out I had to add the string sorting logic to the |
JustinKuli
approved these changes
Mar 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffeyL, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 182d147
into
open-cluster-management-io:main
9 checks passed
This was referenced Mar 27, 2024
mprahl
reviewed
Mar 28, 2024
|
|
||
| for _, statusCond := range policy.Status.Conditions { | ||
| if strings.Contains(statusCond.Message, cnfPrefix) { | ||
| policyMessage = statusCond.Message |
There was a problem hiding this comment.
Is there a reason not to break out of the loop after this assignment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstraintsNotSatisfiablemessage types in the subscription status are formatted"constraints not satisfiable: clause1, clause2, clause3 ...". However, the order of the clauses is nondeterministic, which causes compliance event flapping as each update leads to a different ordering of messages, which in turn triggers another update. This was fixed by sorting the message prior to evaluation.Ref: https://issues.redhat.com/browse/ACM-10204