Handle policy recreation race condition #221
Conversation
|
/hold checking on if this can be called multiple times per evaluation |
mprahl
changed the title
| // If the policy was recreated after it was retrieved from the cache, there could be no compliance | ||
| // set on the parent policy. Updating the status here may prevent a compliance event from being generated on | ||
| // future evaluations so skipping the status update is very important. If sendEvent was true, there is still | ||
| // value to send the compliance event to the parent policy so that this history is not lost before the | ||
| // policy was recreated. |
There was a problem hiding this comment.
Maybe: "If the UID has changed, then the policy has been deleted and created again. Do not update the status, because it was calculated based on a previous version. If sendEvent is true, that event might be useful and it can be emitted. By leaving the status blank, the policy will be reevaluated and send a new event.
When the configuration policy is recreated after the List call completes in the loop in the PeriodicallyExecConfigPolicies method, the old configuration policy status gets set on the new configuration policy which can lead to a compliance event not being set on the replicated parent policy. Relates: https://issues.redhat.com/browse/ACM-10500 Co-authored-by: Justin Kulikauskas <jkulikau@redhat.com> Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
changed the title
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e4c455a
into
open-cluster-management-io:main
When the configuration policy is recreated after the List call completes in the loop in the PeriodicallyExecConfigPolicies method, the old configuration policy status gets set on the new configuration policy which can lead to a compliance event not being set on the replicated parent policy.
Relates:
https://issues.redhat.com/browse/ACM-10500