Fix handling of undefined fields for mustonlyhave
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold to tag to an issue |
dhaiducek
force-pushed
the
e2e-list-handling
branch
from
bf82d57
to
573cb1b
Compare
|
/unhold |
mprahl
reviewed
Apr 11, 2024
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
e2e-list-handling
branch
from
ddaec9b
to
c02ff2d
Compare
If a field exists in the object but wasn't defined for a mustonlyhave policy, we need to check the existing object's fields and set them accordingly, particularly to set them to null. ref: https://issues.redhat.com/browse/ACM-10877 Co-authored-by: Matt Prahl <mprahl@users.noreply.github.com> Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
e2e-list-handling
branch
from
c02ff2d
to
9cfa666
Compare
mprahl
approved these changes
Apr 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5f1d26a
into
open-cluster-management-io:main
9 checks passed
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field exists in the existing object but wasn't defined for a
mustonlyhavepolicy, we need to check the existing object's fields and set them accordingly, particularly to set them to null.