Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of related InstallPlans #239

Commits on May 2, 2024

  1. Reduce number of related InstallPlans

    Previously, the operator policy controller would list all InstallPlans
    in the subscription namespace and filter down to ones it considered
    relevant. Among other things, it used OwnerReferences to do this
    filtering, but those are inconsistently applied by OLM.
    
    Now, it only looks at InstallPlans labelled specifically for the
    subscription in the policy, which seems to be much more reliably set and
    updated by OLM. Generally, only one InstallPlan will have the label,
    which makes it more possible to unambiguously assign a compliance to it
    based on its phase (previously, it was unclear what to assign to
    "historic" InstallPlans).
    
    Much of the controller logic still handles the possibility of there
    being multiple relevant InstallPlans, for robustness.
    
    Refs:
     - https://issues.redhat.com/browse/ACM-11025
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7d533b9 View commit details
    Browse the repository at this point in the history