Hosted mode Testing for OperatorPolicy #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiraeChristineKim
force-pushed
the
ACM-11255
branch
2 times, most recently
from
678c0ee to
212a6ef
Compare
yiraeChristineKim
force-pushed
the
ACM-11255
branch
3 times, most recently
from
dfd8690 to
1b42a21
Compare
| .PHONY: e2e-test | ||
| e2e-test: e2e-dependencies | ||
| $(GINKGO) -v --procs=20 $(E2E_TEST_ARGS) test/e2e | ||
| $(GINKGO) -v --procs=$(E2E_PROCS) $(E2E_TEST_ARGS) test/e2e -- -is_hosted=$(IS_HOSTED) |
There was a problem hiding this comment.
Hosted mode test only 2. Therefore, setting up 20 procs takes more time than unnecessary.
yiraeChristineKim
force-pushed
the
ACM-11255
branch
from
1b42a21 to
1b2effd
Compare
yiraeChristineKim
changed the title
yiraeChristineKim
force-pushed
the
ACM-11255
branch
from
139c396 to
7c1a049
Compare
JustinKuli
reviewed
May 9, 2024
dhaiducek
reviewed
May 9, 2024
yiraeChristineKim
force-pushed
the
ACM-11255
branch
4 times, most recently
from
c6e8924 to
0a22c78
Compare
JustinKuli
reviewed
May 13, 2024
yiraeChristineKim
force-pushed
the
ACM-11255
branch
from
2bf8bee to
577577f
Compare
mprahl
reviewed
May 14, 2024
| @@ -23,7 +23,7 @@ import ( | |||
| "open-cluster-management.io/config-policy-controller/test/utils" | |||
| ) | |||
|
|
|||
| var _ = Describe("Testing OperatorPolicy", Ordered, func() { | |||
| var _ = Describe("Testing OperatorPolicy", Ordered, Label("hosted-as-well"), func() { | |||
There was a problem hiding this comment.
@yiraeChristineKim I vote for Dale's suggestion or using the label supports-hosted.
yiraeChristineKim
force-pushed
the
ACM-11255
branch
4 times, most recently
from
31c0c29 to
1afe943
Compare
The "hosting cluster" should be used for the Policy, OperatorPolicy, and compliance events Ref: https://issues.redhat.com/browse/ACM-11255 Signed-off-by: yiraeChristineKim <yikim@redhat.com>
yiraeChristineKim
force-pushed
the
ACM-11255
branch
from
610488f to
7ce4237
Compare
mprahl
approved these changes
May 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a2ebc6b
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "hosting cluster" should be used for the Policy, OperatorPolicy, and compliance events, while the "target cluster" should be used for all the other resources like Subscription, InstallPlan, etc.
Ref: https://issues.redhat.com/browse/ACM-11255