Prevent subscription creation if opgroup incorrect #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the subscription would be created by an enforced musthave OperatorPolicy regardless of the status of the OperatorGroup. But this could lead to a bad result where the operator is running in the wrong mode because it is not using the correct operatorgroup. While the policy was correctly non-compliant in this case, it should not create the subscription. Refs: - https://issues.redhat.com/browse/ACM-11507 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
yiraeChristineKim
approved these changes
May 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 414cd18
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the subscription would be created by an enforced musthave OperatorPolicy regardless of the status of the OperatorGroup. But this could lead to a bad result where the operator is running in the wrong mode because it is not using the correct operatorgroup. While the policy was correctly non-compliant in this case, it should not create the subscription.
Refs: