Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the OperatorPolicy watches to the managed cluster namespace #259

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented May 31, 2024

Always having a clusterwide watch is incompatible with hosted mode and does not match ConfigurationPolicy.

Related:
https://issues.redhat.com/browse/ACM-11952

@mprahl mprahl requested a review from JustinKuli May 31, 2024 18:02
@openshift-ci openshift-ci bot requested review from dhaiducek and gparvin May 31, 2024 18:02
@mprahl mprahl force-pushed the limit-op-pol-watch branch from 319f92d to 38ffc50 Compare May 31, 2024 18:04
JustinKuli
JustinKuli previously approved these changes May 31, 2024
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was nice to be able to just delete the namespace and not worry specifically about the events, but this makes sense.

Always having a clusterwide watch is incompatible with hosted mode and
does not match ConfigurationPolicy.

Related:
https://issues.redhat.com/browse/ACM-11952

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl
Copy link
Member Author

mprahl commented May 31, 2024

This is blocked on this PR:
stolostron/governance-policy-framework#819

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants