Unified not found behavior for Deployments with CRD and InstallPlan #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffeyL
force-pushed
the
ACM-12040
branch
4 times, most recently
from
39daff0
to
8d74713
Compare
Made edits so both CRD and Deployment report UnknownCompliance when not existing. Ref: https://issues.redhat.com/browse/ACM-12040 Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
mprahl
approved these changes
Jun 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffeyL, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7dcbb66
into
open-cluster-management-io:main
9 checks passed
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed noExistingDeploymentObj to Compliant instead of UnknownCompliancy. This change was made to reduce confusion and to unify behavior with the CRD and InstallPlan, which both report
Compliancewhen there is no existing object instead ofUnknownCompliancy.Ref: https://issues.redhat.com/browse/ACM-12040