Address comments from #276 #278
Conversation
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
| @@ -898,6 +898,8 @@ func (r *ConfigurationPolicyReconciler) handleObjectTemplates(plc *policyv1.Conf | |||
| // validateConfigPolicy returns an error and increments the "invalid-template" error counter metric | |||
| // if the configuration is invalid. | |||
| func (r *ConfigurationPolicyReconciler) validateConfigPolicy(plc *policyv1.ConfigurationPolicy) error { | |||
| log := log.WithValues("policy", plc.GetName()) | |||
There was a problem hiding this comment.
These will help; my bad for missing that I took away some context they had.
At some point, thanks to the event-driven changes, we could consider passing the reconcile ctx to (some) of these functions - that has a logger which OperatorPolicy uses, and I feel like it's kinda nice. We might want to figure out if we can customize it if it has too many default key+values.
There was a problem hiding this comment.
Good idea @JustinKuli! If you're motivated, feel free to make that PR. I'll gladly review it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f4099c0
into
open-cluster-management-io:main
See each commit for details