Add a metric to measure how long resolving policy templates take #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunxiAlexLuo
force-pushed
the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
from
4ce0810
to
1a0710a
Compare
ChunxiAlexLuo
force-pushed
the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
from
6c9ba99
to
873cd66
Compare
gparvin
reviewed
Dec 2, 2022
JustinKuli
reviewed
Dec 5, 2022
There was a problem hiding this comment.
We might want this behind a flag like #77 has, so the metric could be turned off.
ChunxiAlexLuo
force-pushed
the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
from
693b5b9
to
a30de0a
Compare
ChunxiAlexLuo
force-pushed
the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
8 times, most recently
from
0906e17
to
8919ccf
Compare
Signed-off-by: Chunxi Luo <chuluo@redhat.com>
ChunxiAlexLuo
force-pushed
the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
from
babf6c0
to
ff0381c
Compare
|
STEP: Checking metric endpoint for policy template counter for policy policy-update-referenced-object |
gparvin
approved these changes
Dec 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChunxiAlexLuo, gparvin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChunxiAlexLuo
deleted the
Add-a-metric-to-measure-how-long-resolving-policy-templates-take
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chunxi Luo chuluo@redhat.com
https://github.com/stolostron/backlog/issues/25358