Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pruning when the CRD is being deleted #86

Commits on Dec 13, 2022

  1. Skip pruning when the CRD is being deleted

    In some upgrade cases, the ConfigurationPolicy CRD might be temporarily
    removed. This usually triggers all of the ConfigurationPolicies to be
    deleted, which would trigger the pruning behavior. But deleting those
    resources could cause problems, even though they might immediately be
    recreated when the upgrade finishes. Even outside of upgrades, deleting
    the CRD "by accident" should probably not trigger the prune behavior.
    
    Now, before pruning anything, the controller checks if the CRD is being
    deleted.
    
    BUG: `DeleteIfCreated` will not work perfectly through an upgrade: if
    the object was created by the policy *before* the CRD was removed, it
    won't be pruned by the policy after everything is re-created. But
    missing a deletion seems like a better behavior than deleting extra
    things.
    
    Refs:
     - https://issues.redhat.com/browse/ACM-2355
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    25e93f5 View commit details
    Browse the repository at this point in the history