Set OperatorPolicy default namespace option #130
Conversation
This sets the command-line flag added by the companion PR open-cluster-management-io/config-policy-controller#204 This only sets that flag when the managed cluster is using OpenShift v4. It should be noted that this flag is *not* currently configurable by the user (it is not for example exposed through an annotation). Refs: - https://issues.redhat.com/browse/ACM-9896 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
9896-oppol-defaulting-namespace
branch
from
ac67b97
to
25fb1aa
Compare
|
Shouldn't be merged until open-cluster-management-io/config-policy-controller#204 is done. |
|
I couldn't come up with a good way to test whether this supplies the correct value on OpenShift in a test here, but if anyone things it's necessary (or has any ideas to make it easy), I can work on it more. |
| @@ -111,6 +111,11 @@ func getValues(cluster *clusterv1.ManagedCluster, | |||
| // Disable OperatorPolicy if the cluster is not on OpenShift version 4.y | |||
| userValues.OperatorPolicy["disabled"] = cluster.Labels["openshiftVersion-major"] != "4" | |||
|
|
|||
| // Set the default namespace for OperatorPolicy for OpenShift 4 | |||
| if cluster.Labels["openshiftVersion-major"] == "4" { | |||
| userValues.OperatorPolicy["default-namespace"] = "openshift-operators" | |||
There was a problem hiding this comment.
Just curious If openshift 5.xx is released in the future, should we edit this?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 010070d
into
open-cluster-management-io:main
This sets the command-line flag added by the companion PR open-cluster-management-io/config-policy-controller#204
This only sets that flag when the managed cluster is using OpenShift v4. It should be noted that this flag is not currently configurable by the user (it is not for example exposed through an annotation).
Refs: