Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the hosting cluster version when applicable #142

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Mar 14, 2024

This leverages the refactor in open-cluster-management-io/addon-framework#251.

@mprahl
Copy link
Member Author

mprahl commented Mar 14, 2024

The CI will pass after open-cluster-management-io/ocm#378

@mprahl mprahl changed the title WIP: Use the hosting cluster version when applicable Use the hosting cluster version when applicable Mar 15, 2024
@mprahl mprahl marked this pull request as ready for review March 15, 2024 16:52
@openshift-ci openshift-ci bot requested a review from dhaiducek March 15, 2024 16:52
@mprahl
Copy link
Member Author

mprahl commented Mar 15, 2024

/cc @dhaiducek

pkg/addon/common.go Outdated Show resolved Hide resolved
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Addon-framework is still really head-scratching for me, but this seems right! 😄

Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants