-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a launch.json file for local development #146
Add a launch.json file for local development #146
Conversation
Relates: https://issues.redhat.com/browse/ACM-10885 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
"request": "launch", | ||
"mode": "auto", | ||
"program": "${workspaceFolder}/main.go", | ||
"args": ["--kubeconfig=${workspaceFolder}/kubeconfig_cluster1", "controller", "--namespace=open-cluster-management"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubeconfig_cluster1_e2e
"args": ["--kubeconfig=${workspaceFolder}/kubeconfig_cluster1", "controller", "--namespace=open-cluster-management"], | |
"args": ["--kubeconfig=${workspaceFolder}/kubeconfig_cluster1_e2e", "controller", "--namespace=open-cluster-management"], |
kubeconfig_cluster1 didn't work well for me I couldn't get "ns" maybe role issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it before submitting this PR and it ran. What error are you getting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working for me also. (In general we shouldn't be using the *_e2e
kubeconfigs to run the controller since if there is an issue with RBAC, we should address that instead.)
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
af0eca7
into
open-cluster-management-io:main
Relates:
https://issues.redhat.com/browse/ACM-10885