Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade addon-framework to 0.9.3 #154

Merged
merged 1 commit into from
May 29, 2024
Merged

Upgrade addon-framework to 0.9.3 #154

merged 1 commit into from
May 29, 2024

Conversation

xuezhaojun
Copy link
Member

No description provided.

@dhaiducek
Copy link
Member

dhaiducek commented May 28, 2024 •
edited
Loading

@xuezhaojun What commit needs to be included here? We need the WithManagedClusterClient() function, so technically the version we've tagged here diverged from v0.9.3. Would it be sufficient to tag the latest commit from main to pick up the commit?

PR:

@dhaiducek dhaiducek mentioned this pull request May 28, 2024
Merged
@xuezhaojun
Copy link
Member Author

Hi, @dhaiducek No worries, we are working on cherry-pick WithManageClusterClient into 0.9 branch in this PR: open-cluster-management-io/addon-framework#272.

@xuezhaojun xuezhaojun force-pushed the upgrade-addon-framework-to-0.9.3 branch from fa01fb8 to 15d850e Compare May 29, 2024 01:06
@xuezhaojun xuezhaojun closed this May 29, 2024
@xuezhaojun xuezhaojun force-pushed the upgrade-addon-framework-to-0.9.3 branch from 15d850e to 9969b11 Compare May 29, 2024 01:08
@xuezhaojun xuezhaojun reopened this May 29, 2024
@xuezhaojun
Upgrade addon-framework to 0.9.3.
a3fb5f2 
Signed-off-by: GitHub <noreply@github.com>
@xuezhaojun xuezhaojun force-pushed the upgrade-addon-framework-to-0.9.3 branch from 0891e58 to a3fb5f2 Compare May 29, 2024 01:45
@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 70230fa into open-cluster-management-io:main May 29, 2024
7 checks passed
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request May 29, 2024
Merged
@xuezhaojun xuezhaojun deleted the upgrade-addon-framework-to-0.9.3 branch May 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaiducek dhaiducek dhaiducek approved these changes

@gparvin gparvin Awaiting requested review from gparvin

@yiraeChristineKim yiraeChristineKim Awaiting requested review from yiraeChristineKim

Assignees

@dhaiducek dhaiducek

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuezhaojun @dhaiducek @openshift-merge-robot