Record compliance events in the compliance history API with nanoseconds #120
Conversation
| @@ -198,16 +199,19 @@ var _ = Describe("Compliance API recording", Ordered, Label("compliance-events-a | |||
| g.Expect(requests[0].Event.Message).To(Equal("Halt, who goes there?")) | |||
| g.Expect(requests[0].ParentPolicy.KeyID).To(BeEquivalentTo(1)) | |||
| g.Expect(requests[0].Policy.KeyID).To(BeEquivalentTo(3)) | |||
| g.Expect(requests[0].Event.Timestamp.Nanosecond()).ToNot(Equal(0)) | |||
There was a problem hiding this comment.
It's possible that this could actually be 0, though it's very unlikely since it'd be a 1 in 999999999 chance for each event. If the reviewer is spooked about this flake happening, I can remove the check.
There was a problem hiding this comment.
Do you mean there is a possibility of the flaky test?
There was a problem hiding this comment.
Yes because it's possible the the actual nanosecond of when the event was generated was 0. I'll just change it to be a unit test instead.
This helps with ordering when compliance events have a timestamp that is the same down to the second. Relates: https://issues.redhat.com/browse/ACM-10155 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
history-event-precision
branch
from
7b58b7a
to
5b39cb7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a3c206c
into
open-cluster-management-io:main
This helps with ordering when compliance events have a timestamp that is the same down to the second.
Relates:
https://issues.redhat.com/browse/ACM-10155