Run framework tests on OCM PRs #125
Conversation
ref: https://issues.redhat.com/browse/ACM-4811 Signed-off-by: Jason Zhang <jaszhang@redhat.com>
|
/test all |
|
@zyjjay: No presubmit jobs available for open-cluster-management-io/governance-policy-framework-addon@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
zyjjay
force-pushed
the
ACM-4811
branch
2 times, most recently
from
ba6c130
to
51d2c66
Compare
| kind load docker-image $(REGISTRY)/$(IMG):$(TAG) --name $(KIND_NAME) | ||
| kubectl annotate -n $(subst -hosted,,$(KIND_NAMESPACE)) --overwrite managedclusteraddon governance-policy-framework\ | ||
| addon.open-cluster-management.io/values='{"global":{"imagePullPolicy": "Never", "imageOverrides":{"governance_policy_framework_addon": "$(REGISTRY)/$(IMG):$(TAG)"}}}' | ||
|
|
There was a problem hiding this comment.
oh why? imagePullPolicy": "Never"
| .PHONY: kind-deploy-controller-dev-addon | ||
| kind-deploy-controller-dev-addon: | ||
| @echo Hosted mode test | ||
| kind load docker-image $(REGISTRY)/$(IMG):$(TAG) --name $(KIND_NAME) | ||
| kubectl annotate -n $(subst -hosted,,$(KIND_NAMESPACE)) --overwrite managedclusteraddon governance-policy-framework\ | ||
| addon.open-cluster-management.io/values='{"global":{"imagePullPolicy": "Never", "imageOverrides":{"governance_policy_framework_addon": "$(REGISTRY)/$(IMG):$(TAG)"}}}' |
There was a problem hiding this comment.
I cherry-picked this commit from stolostron in order to fix the hosted mode tests. Is there a reason we would use governance_policy_framework over the framework_addon?
zyjjay
force-pushed
the
ACM-4811
branch
2 times, most recently
from
6fab8b3
to
6961389
Compare
Ref: https://issues.redhat.com/browse/ACM-6966 Signed-off-by: Yi Rae Kim <yikim@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yiraeChristineKim, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e5b17fc
into
open-cluster-management-io:main
ref: https://issues.redhat.com/browse/ACM-4811