Start and stop the Gatekeeper status sync controller dynamically #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
changed the title
mprahl
force-pushed
the
ACM-10966
branch
3 times, most recently
from
32ed675
to
56a9b2f
Compare
JustinKuli
reviewed
Apr 10, 2024
mprahl
force-pushed
the
ACM-10966
branch
3 times, most recently
from
f9c4714
to
3f805f0
Compare
|
@JustinKuli could you please take another look? |
JustinKuli
reviewed
Apr 10, 2024
Comment on lines
+989
to
+1021
| select { | ||
| case <-ctx.Done(): | ||
| // Stop the retry watcher if the parent context is canceled. It likely already is stopped, but this is not | ||
| // documented behavior. | ||
| watcher.Stop() | ||
|
|
||
| // Satisfy the lostcancel linter but if this code is reached, then we know mgrCtx is cancelled since the | ||
| // parent context (ctx) is cancelled. | ||
| if mgrCtxCancel != nil { | ||
| mgrCtxCancel() | ||
| } | ||
|
|
||
| return | ||
| case <-watcher.Done(): | ||
| // Restart the watcher on the next loop since the context wasn't closed which indicates it was not stopped | ||
| // on purpose. | ||
| watcher = nil | ||
| case result := <-watcher.ResultChan(): | ||
| // If the CRD is added, then Gatekeeper is installed. | ||
| if result.Type == apiWatch.Added { | ||
| gatekeeperInstalled = true | ||
| } else if result.Type == apiWatch.Deleted { | ||
| gatekeeperInstalled = false | ||
| } | ||
| } |
There was a problem hiding this comment.
😎 It's beautiful! A select statement where every case is a real thing to wait for!
Rather than rely on a health probe failing if the Gatekeeper installation status changes, just dynamically start and stop a new manager. Relates: https://issues.redhat.com/browse/ACM-10966 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
changed the title
Thanks @JustinKuli! I addressed your comments and I had forgotten about the use of the wait group in the main function, so I took that into account when the Gatekeeper sync manager is running. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3bc0a9e
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than rely on a health probe failing if the Gatekeeper installation status changes, just dynamically start and stop a new manager.
Relates:
https://issues.redhat.com/browse/ACM-10966