Use the dependency watcher cache in gatekeeper-constraint-status-sync #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts to use the Stolostron fork and also sets the audit interval to 10 seconds to speed up the tests in case17. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
This also improves the situation when the ConstraintTemplate is removed and the policy still deploys a Constraint. Relates: https://issues.redhat.com/browse/ACM-11200 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 64304d4
into
open-cluster-management-io:main
9 checks passed
| @@ -230,7 +230,8 @@ install-resources: | |||
| -kubectl apply -k deploy/hubpermissions --kubeconfig=$(HUB_CONFIG)_e2e | |||
| @if [ "$(KIND_VERSION)" != "minimum" ]; then \ | |||
| echo installing Gatekeeper on the managed cluster; \ | |||
| kubectl apply -f https://raw.githubusercontent.com/open-policy-agent/gatekeeper/v3.11.0/deploy/gatekeeper.yaml --kubeconfig=$(MANAGED_CONFIG)_e2e; \ | |||
| curl -L https://raw.githubusercontent.com/stolostron/gatekeeper/release-3.15/deploy/gatekeeper.yaml | sed 's/- --disable-cert-rotation/- --disable-cert-rotation\n - --audit-interval=10/g' | kubectl apply --kubeconfig=$(MANAGED_CONFIG)_e2e -f -; \ | |||
There was a problem hiding this comment.
maybe it is better that release-3.15 being a parameter. but already merged sorr y for late
There was a problem hiding this comment.
we can use this(from dale)
GATEKEEPER_TAG=$(shell curl -L https://api.github.com/repos/stolostron/gatekeeper/tags | jq -r '.[].name' | sort --version-sort | grep $(echo $(GATEKEEPER_VERSION) | cut -d '.' -f 1-2) | tail -1)
There was a problem hiding this comment.
@yiraeChristineKim won't we hit API rate limiting that way though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit updates the E2E environment Gatekeeper to 3.15 and uses the Stolostron fork.
This also improves the situation when the ConstraintTemplate is removed and the policy still deploys a Constraint.
Relates:
https://issues.redhat.com/browse/ACM-11200