Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-runtime to 0.17.3 #137

Merged

Conversation

JeffeyL
Copy link
Contributor

@JeffeyL JeffeyL commented Apr 29, 2024

Changes required to update controller-runtime to 0.17.3

Ref: https://issues.redhat.com/browse/ACM-10835

go.mod Show resolved Hide resolved
Changes required to update controller-runtime to 0.17.3

Ref: https://issues.redhat.com/browse/ACM-10835
Signed-off-by: Jeffrey Luo <jeluo@redhat.com>
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 30, 2024
Copy link

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeffeyL, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cfa2e4f into open-cluster-management-io:main Apr 30, 2024
9 checks passed
@JeffeyL JeffeyL requested a review from JustinKuli April 30, 2024 12:50
@JeffeyL
Copy link
Contributor Author

JeffeyL commented Apr 30, 2024

Whoops, didn't mean to request another review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants