emit pending on mapping error #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Kutler <wkutler@redhat.com>
willkutler
requested review from
JustinKuli
and removed request for
gparvin and
ChunxiAlexLuo
JustinKuli
approved these changes
Nov 16, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, willkutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Will Kutler wkutler@redhat.com
Previously we were generating violations on mapping errors for dependencies (ex: wrong API group for a dependency). @JustinKuli and I decided this was a bit confusing for users, since the NonCompliant status generated by this error gives the impression that the dependency passed and the policy generated a violation, rather than the other way around. This change makes all mapping errors show the same Pending status as dependencies that are correctly formatted but do not exist.