Unowned template panic #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Previously, if a Policy defined a template that already exists, it assumed that another Policy had defined it, and tried to get its owner reference in order to give a helpful error message. But if the template was created outside of a Policy, then this process would panic. Refs: - https://issues.redhat.com/browse/ACM-3416 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
gparvin
approved these changes
Feb 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
to stolostron/governance-policy-template-sync
that referenced
this pull request
Mar 29, 2023
Previously, if a Policy defined a template that already exists, it assumed that another Policy had defined it, and tried to get its owner reference in order to give a helpful error message. But if the template was created outside of a Policy, then this process would panic. Refs: - https://issues.redhat.com/browse/ACM-4211 - open-cluster-management-io/governance-policy-framework-addon#29 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
mprahl
pushed a commit
to mprahl/governance-policy-framework-addon
that referenced
this pull request
Apr 19, 2023
…y-framework-addon: open-cluster-management-io#29 (open-cluster-management-io#36) * Refactor: new hubApplyPolicy function Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 8654c6f) * Emit template-error if template already exists Previously, if a Policy defined a template that already exists, it assumed that another Policy had defined it, and tried to get its owner reference in order to give a helpful error message. But if the template was created outside of a Policy, then this process would panic. Refs: - https://issues.redhat.com/browse/ACM-3416 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit c07ac53) --------- Co-authored-by: Justin Kulikauskas <jkulikau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring as well, but the more important bit is this commit:
Previously, if a Policy defined a template that already exists, it assumed that another Policy had defined it, and tried to get its owner reference in order to give a helpful error message. But if the template was created outside of a Policy, then this process would panic.
Refs: