Conditionally clean up Gatekeeper Constraints #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
gate-gatekeeper
branch
from
702c8f4
to
b885516
Compare
JustinKuli
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
/hold for @mprahl
LGTM! It's easier than I would have expected to transition the global back to false, so that's really nice.
mprahl
reviewed
Apr 3, 2023
mprahl
reviewed
Apr 3, 2023
mprahl
reviewed
Apr 3, 2023
mprahl
reviewed
Apr 3, 2023
dhaiducek
force-pushed
the
gate-gatekeeper
branch
from
b885516
to
8319236
Compare
dhaiducek
force-pushed
the
gate-gatekeeper
branch
from
8319236
to
0c83617
Compare
|
/unhold |
mprahl
reviewed
Apr 3, 2023
dhaiducek
force-pushed
the
gate-gatekeeper
branch
2 times, most recently
from
7da2697
to
a2c7f1d
Compare
mprahl
approved these changes
Apr 4, 2023
|
/hold for an additional comment |
mprahl
reviewed
Apr 4, 2023
Listing Gk ConstraintTemlates was refreshing the discovery API. This adds a global boolean to only attempt cleanup when a Constraint was previously synced successfully. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
gate-gatekeeper
branch
from
a2c7f1d
to
266c709
Compare
mprahl
approved these changes
Apr 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing Gatekeeper Constraints was refreshing the discovery API. This adds a global boolean to only attempt cleanup when a Constraint was previously synced successfully.