Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop resetting the policy template compliance when already reset #47

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Apr 4, 2023

When it's already reset or is empty, the patch fails and leads to the reconcile request being retried until the corresponding controller that provides status for the policy template.

Relates:
https://issues.redhat.com/browse/ACM-4486

When it's already reset or is empty, the patch fails and leads to the
reconcile request being retried until the corresponding controller that
provides status for the policy template.

Relates:
https://issues.redhat.com/browse/ACM-4486

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants