GoSec fixes and improvements #59
Conversation
Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
/cc @dhaiducek I don't know if something like this gosec change would be better in a common makefile? |
The KinD tests action will now run the gosec-scan, and that target will fail if any vulnerabilities are found. The target was also configured to ignore the test code. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Information about the gatekeeper pods might help if those tests fail. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
/hold I found the other test issue |
I was going to do it, but if you have a moment, it can go here: https://github.com/stolostron/governance-policy-framework/blob/02d52d5811bfa706ec84fcd9a2f153a46ae9aa5b/build/common/Makefile.common.mk#L108 |
The test is meant to ensure that the gatekeeper-sync is not emitting the same event multiple times in a row. But the assertion was failing sometimes because of duplicate events from template-errors. Those will sometimes occur during normal (correct) operation of the template-sync. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
/unhold 🤞 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes some issues identified by GoSec, and incorporates the scan into CI here so it will fail when other issues are found.