Check v1beta1 CRD for policy template label #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On older versions of k8s where the v1 version of CRDs is not available, this method was preventing the controller from working. Refs: - https://issues.redhat.com/browse/ACM-5326 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
dhaiducek
approved these changes
May 4, 2023
There was a problem hiding this comment.
I double checked the addon-controller. The CRDs don't have the label, so would you please add it there also?
- v1beta1 CertPolicy: https://github.com/stolostron/governance-policy-addon-controller/blob/a9d7348d8292a227d069d2f3199acd20243a686b/pkg/addon/certpolicy/manifests/managedclusterchart/templates/policy.open-cluster-management.io_certificatepolicy_crd.yaml#L12
- v1 CertPolicy:https://github.com/stolostron/governance-policy-addon-controller/blob/a9d7348d8292a227d069d2f3199acd20243a686b/pkg/addon/certpolicy/manifests/managedclusterchart/templates/policy.open-cluster-management.io_certificatepolicy_crd.yaml#L189
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older versions of k8s where the v1 version of CRDs is not available, this method was preventing the controller from working.
Refs: