Allow uninstall mode to be cancelled #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the running container could only move *into* uninstallation mode - once it was in that mode, it needed to be restarted to restore normal operations. To improve the reliability of uninstall/reinstall scenarios, it can now move back into normal operations automatically. All reconciles that were skipped during uninstallation are now just delayed 5 minutes. A "normal" uninstallation should be completed within that amount of time. If the uninstallation was aborted, then this should ensure no reconciles are permanently missed. Refs: - https://issues.redhat.com/browse/ACM-6941 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
mprahl
approved these changes
Aug 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit c7dfba5
into
open-cluster-management-io:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the running container could only move into uninstallation mode - once it was in that mode, it needed to be restarted to restore normal operations. To improve the reliability of uninstall/reinstall scenarios, it can now move back into normal operations automatically.
All reconciles that were skipped during uninstallation are now just delayed 5 minutes. A "normal" uninstallation should be completed within that amount of time. If the uninstallation was aborted, then this should ensure no reconciles are permanently missed.
Refs: