Adjust the error to check for the ConstraintTemplate CRD missing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
reviewed
Sep 15, 2023
JustinKuli
reviewed
Sep 15, 2023
mprahl
force-pushed
the
fix-gk-crd-missing
branch
from
0776bcf
to
ad45b33
Compare
mprahl
force-pushed
the
fix-gk-crd-missing
branch
from
ad45b33
to
ebd2e16
Compare
After updating to controller-runtime 0.15, it seems that a different error is returned when a CRD is missing, so it caused an API server hit every time the policy template sync controller reconciled. This uses the new error. Relates: stolostron/backlog#27375 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
fix-gk-crd-missing
branch
from
ebd2e16
to
fac2ec1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit da52641
into
open-cluster-management-io:main
4 checks passed
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to controller-runtime 0.15, it seems that a different error is returned when a CRD is missing, so it caused an API server hit every time the policy template sync controller reconciled. This uses the new error.
Relates:
https://github.com/stolostron/backlog/issues/27375