Update cache filtering granularity to align with SA permissions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed when hub/managed managers are instantiated, the cache options is now populated with the correct field selector on secrets. Updated controller-runtime to v0.16.3. Breaking changes: 1. MetricsBindAddress is now inside Metrics struct as BindAddress 2. Namespaces in cache.Options is changed to DefaultNamespaces as a map where the key is the namespace, and value is the cache config that describes all potential options for a given watch in the namespace. More info: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 ref: https://issues.redhat.com/browse/ACM-6869 Signed-off-by: Jason Zhang <jaszhang@redhat.com>
zyjjay
force-pushed
the
ACM-6869-fix2
branch
from
0b4d700
to
e445d1b
Compare
mprahl
approved these changes
Nov 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9d7cd6c
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed when hub/managed managers are instantiated, the cache options is now populated with the correct field selector on secrets.
Updated controller-runtime to v0.16.3.
Breaking changes:
ref: https://issues.redhat.com/browse/ACM-6869