Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure url and cabundle for self managed cluster #135

Conversation

tamalsaha
Copy link
Contributor

@tamalsaha tamalsaha commented Mar 9, 2024

Without this fix, addons do not work in self managed cluster.

@openshift-ci openshift-ci bot requested review from qiujian16 and ycyaoxdu March 9, 2024 14:36
@tamalsaha tamalsaha force-pushed the self-approve branch 3 times, most recently from 68321f9 to ff48f9a Compare March 9, 2024 20:25
if err != nil {
return err
}
apiserverURL, err := helpers.GetAPIServer(kubeClient)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe copy the methods from clusteradm repo. I feel it is a little heavy to depend on clusteradm repo only for util. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can copy it. Will it make sense to move this common methods to the sdk-go repo? If so, what package path will make sense? If not, I can copy the code here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, make sense to move to sdk-go

Copy link
Contributor Author

@tamalsaha tamalsaha Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL open-cluster-management-io/sdk-go#23

Once that is merged, I can update both here and in the clusteradm repo.

Signed-off-by: Tamal Saha <tamal@appscode.com>
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, tamalsaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 67c9200 into open-cluster-management-io:main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants