Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reduce permission for cluster manager #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from xuezhaojun and zhujian7 December 4, 2023 01:44
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (f89d535) to head (eee814d).
Report is 280 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   61.75%   61.73%   -0.03%     
==========================================
  Files         132      132              
  Lines       13992    13992              
==========================================
- Hits         8641     8638       -3     
- Misses       4585     4587       +2     
- Partials      766      767       +1     
Flag Coverage Δ
unit 61.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member Author

/hold

@zhiweiyin318
Copy link
Member

/lgtm
add a followup to update the hub-hosted mode deploy to set enable-hosted-mode flag.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Apr 7, 2024

This pull request is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added Stale and removed Stale labels Apr 7, 2024
Copy link

github-actions bot commented Aug 6, 2024

This pull request is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

@github-actions github-actions bot added Stale and removed Stale labels Aug 6, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stale label to prevent this issue from being closed.

@github-actions github-actions bot added Stale and removed Stale labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants