Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix too many csrs in registration. #643

Closed

Conversation

xuezhaojun
Copy link
Member

Summary

Related issue(s)

Fixes #

Signed-off-by: xuezhaojun <zxue@redhat.com>
Copy link
Contributor

openshift-ci bot commented Oct 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.07%. Comparing base (43c3500) to head (06e6d7d).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registration/register/secret_controller.go 66.66% 1 Missing ⚠️
...kg/registration/spoke/registration/registration.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         181      181           
  Lines       14166    14172    +6     
=======================================
+ Hits         9077     9081    +4     
- Misses       4186     4188    +2     
  Partials      903      903           
Flag Coverage Δ
unit 64.07% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun closed this Oct 16, 2024
@xuezhaojun xuezhaojun deleted the fix-too-many-csr branch October 22, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant