🐛 Fix duplicate deployment names in klusterlet-agent availability message

[RokibulHasan7]

Summary

Related issue(s)

Fixes #

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RokibulHasan7
Once this PR has been reviewed and has the lgtm label, please assign dongbeiqing91 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.05%. Comparing base (865ae06) to head (980cd44).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   63.04%   63.05%   +0.01%     
==========================================
  Files         182      182              
  Lines       17606    17612       +6     
==========================================
+ Hits        11100    11106       +6     
  Misses       5594     5594              
  Partials      912      912              

Flag	Coverage Δ
unit	63.05% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhujian7]

Suggested change

	IsSingleton := helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode)
	isSingleton := helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode)

[RokibulHasan7]

updated

[zhujian7]

Another option is to deduplicate the agents in the checkAgentsDeploymentAvailable func, like:

// Check agent deployments, if both of them have at least 1 available replicas, return available condition
func checkAgentsDeploymentAvailable(ctx context.Context, kubeClient kubernetes.Interface, agents []klusterletAgent) metav1.Condition {
	var availableMessages []string
	components := sets.Set[string]{}  ### import "k8s.io/apimachinery/pkg/util/sets"
	for _, agent := range agents {
		componentID := fmt.Sprintf("%s-%s", agent.namespace, agent.deploymentName)
		if components.Has(componentID) {
			continue
		}
		components.Insert(componentID)
		deployment, err := kubeClient.AppsV1().Deployments(agent.namespace).Get(ctx, agent.deploymentName, metav1.GetOptions{})
		...
}