-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix duplicate deployment names in klusterlet-agent availability message #671
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rokibul Hasan <mdrokibulhasan@appscode.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RokibulHasan7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
+ Coverage 63.04% 63.05% +0.01%
==========================================
Files 182 182
Lines 17606 17612 +6
==========================================
+ Hits 11100 11106 +6
Misses 5594 5594
Partials 912 912
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -78,24 +78,27 @@ func (k *klusterletStatusController) sync(ctx context.Context, controllerContext | |||
registrationDeploymentName := fmt.Sprintf("%s-registration-agent", klusterlet.Name) | |||
workDeploymentName := fmt.Sprintf("%s-work-agent", klusterlet.Name) | |||
|
|||
if helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode) { | |||
IsSingleton := helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IsSingleton := helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode) | |
isSingleton := helpers.IsSingleton(klusterlet.Spec.DeployOption.Mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Another option is to deduplicate the agents in the
|
Summary
Related issue(s)
Fixes #