🌱 enable leader election of klusterlet-agent on single node managed cluster #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
275a62f to
c0fa479
Compare
haoqing0110
changed the title
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
c0fa479 to
1d6e452
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 185 185
Lines 17765 17765
=======================================
Hits 11258 11258
+ Misses 5577 5576 -1
- Partials 930 931 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
1d6e452 to
39b75b5
Compare
…sters Signed-off-by: Qing Hao <qhao@redhat.com>
haoqing0110
force-pushed
the
br_agent-leader-election
branch
from
39b75b5 to
81e8c59
Compare
|
/assign @elgnay @qiujian16 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8544ff1
into
open-cluster-management-io:main
15 checks passed
xuezhaojun
added a commit
to xuezhaojun/OCM
that referenced
this pull request
Nov 19, 2024
…aged clusters (open-cluster-management-io#695)" This reverts commit 8544ff1. Signed-off-by: xuezhaojun <zxue@redhat.com>
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The leader election of the klusterlet-agent is disabled on the single node managed cluster to speed up the restart procedure (open-cluster-management-io/registration-operator#193). While it might cause that two pods with different configuration, such as images or bootstrap config, running at the same time. Some unexpected behavior happens in this situation, for example, when old and new agents both exist, they override hub-kubeconfig-secret with different value and trigger each other create csr constantly.
To fix those issues, it is necessary to enable the leader election of the klusterlet-agent on the single node managed cluster.
Related issue(s)
Fixes #