✨ Starting aws registration by spoke by assuming IAM role on startup and adding annotations to ManagedCluster CR

[jaswalkiranavtar]

Summary

This PR contains

• AWS role assumption on start up by spoke
• Adding annotations to ManagedCluster CR so that hub can recognize it as a registration request with AWS IAM auth
• Mounting dot-aws directory needed by aws-cli

Related issue(s)

#514

[codecov]

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (2710e0e) to head (2ab4069).

Files with missing lines	Patch %	Lines
pkg/common/helpers/aws.go	0.00%	7 Missing ⚠️
pkg/registration/spoke/options.go	0.00%	5 Missing and 1 partial ⚠️
...lers/klusterletcontroller/klusterlet_controller.go	86.48%	4 Missing and 1 partial ⚠️
pkg/registration/spoke/spokeagent.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   63.41%   63.43%   +0.01%     
==========================================
  Files         185      186       +1     
  Lines       17802    17843      +41     
==========================================
+ Hits        11290    11318      +28     
- Misses       5581     5591      +10     
- Partials      931      934       +3     

Flag	Coverage Δ
unit	63.43% <58.18%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[mikeshng]

/assign @qiujian16

[mikeshng]

Hi @zhujian7 @zhiweiyin318 @dongbeiqing91

Bulk of the changes in this PR is related to the operator. Could you PTAL whenever you have some cycles? Thanks.

[mikeshng]

This is great! Thank you for your contribution!

Left some comments. Regarding showing the error on klusterlet condition, maybe wait for the operator maintainers and/or Qiu Jian's feedback.

[jaswalkiranavtar]

This is great! Thank you for your contribution!

Left some comments. Regarding showing the error on klusterlet condition, maybe wait for the operator maintainers and/or Qiu Jian's feedback.

Addressed comments other than adding failure conditions. Please show us a sample on how to add failure condition.

[jaswalkiranavtar]

Thanks for approving api repo PR. Do you have any further comments on this one?

[mikeshng]

Great work on this PR!

Huge thank you to all the code reviewers for taking the time to provide valuable feedback. I’ve ensured that all your comments have been addressed. If there are any additional concerns, @jaswalkiranavtar and his team will address them in another PR quickly.

Typically, I am not the one to approve PRs involving this area of the codebase. However, I’m making an exception here as, based on my review, all changes are contained within the hub on EKS associated flags. This containment minimizes the risk of regression to the main/latest branch. To accommodate the contributors' schedules and planning, I’m approving this merge based on the prior reviews, comments, and my own assessment.

/approve

/lgtm

[jnpacker]

Reviewed the code and comments. /LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaswalkiranavtar, jnpacker, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jnpacker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment