Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add cluster decorator interface in register #752

Conversation

qiujian16
Copy link
Member

And refactor creating to controller to call decorators

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and xuezhaojun December 9, 2024 05:28
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@qiujian16 qiujian16 force-pushed the cluster-decorator-interface branch from 9f48e25 to f6d58ca Compare December 9, 2024 06:14
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.36%. Comparing base (a138a54) to head (f013745).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...stration/spoke/registration/creating_controller.go 78.37% 6 Missing and 2 partials ⚠️
pkg/registration/register/csr/csr.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   63.32%   63.36%   +0.04%     
==========================================
  Files         186      187       +1     
  Lines       17912    17932      +20     
==========================================
+ Hits        11343    11363      +20     
- Misses       5634     5635       +1     
+ Partials      935      934       -1     
Flag Coverage Δ
unit 63.36% <78.26%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And refactor creating to controller to call decorators

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant