-
Notifications
You must be signed in to change notification settings - Fork 30
watch placementscore during scheduling #89
watch placementscore during scheduling #89
Conversation
refactor eventhandler using index Signed-off-by: Jian Qiu <jqiu@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@haoqing0110 should I add a test to ensure it can reflect on score update or there is already one? |
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 we have a benchmark testing on the placement decision generation with addon score. https://github.com/open-cluster-management-io/placement/blob/main/test/benchmark/benchmark_test.go. But the score doesn't change so far, may need to update that. |
/lgtm |
I tested this with two hosting clusters. As placement score changes, I saw an immediate change in the placement decision. Thank you so much! |
/unhold |
refactor eventhandler using index
Signed-off-by: Jian Qiu jqiu@redhat.com