Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

watch placementscore during scheduling #89

Merged

Conversation

qiujian16
Copy link
Member

refactor eventhandler using index

Signed-off-by: Jian Qiu jqiu@redhat.com

refactor eventhandler using index

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from haoqing0110 and suigh November 24, 2022 06:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

#87

@qiujian16
Copy link
Member Author

@haoqing0110 should I add a test to ensure it can reflect on score update or there is already one?

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@haoqing0110
Copy link
Member

haoqing0110 commented Nov 24, 2022

@qiujian16 we have a benchmark testing on the placement decision generation with addon score. https://github.com/open-cluster-management-io/placement/blob/main/test/benchmark/benchmark_test.go. But the score doesn't change so far, may need to update that.

@elgnay
Copy link
Collaborator

elgnay commented Nov 24, 2022

/lgtm
/hold Hold the PR in case someone else wants to take a look.

@rokej
Copy link

rokej commented Nov 28, 2022

I tested this with two hosting clusters. As placement score changes, I saw an immediate change in the placement decision. Thank you so much!

@qiujian16
Copy link
Member Author

/unhold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants