Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing policy dependencies #411

Closed
wants to merge 1 commit into from
Closed

Removing policy dependencies #411

wants to merge 1 commit into from

Conversation

levenhagen
Copy link
Contributor

I think having this dependency in this policy won't be ok because the other previous SSO policies are not deployed to managed clusters, so the dependency will stop this policy from being executed in managed clusters other than the local-cluster.

I think having this dependency in this policy won't be ok because the other previous SSO policies are not deployed to managed clusters, so the dependency will stop this policy from being executed in managed clusters other than the local-cluster.
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: levenhagen
Once this PR has been reviewed and has the lgtm label, please assign yiraechristinekim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 432c00d Removing policy dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhaiducek
Copy link
Member

@levenhagen Sorry for the delay here! Would you please add the DCO signoff to this PR? Since it's a single commit, doing an "amend" and then a force push should do it:

git commit --amend --signoff
git push --force

@levenhagen levenhagen closed this by deleting the head repository Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants