Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use copyMethod: Snapshot for ReplicationDestination #444

Merged

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Jan 18, 2024

Update ReplicationDestination to use copyMethod: Snapshot
This will force the applications using the PVC to wait until the restore completes, before being able to use the PVC

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
@birsanv
Copy link
Contributor Author

birsanv commented Jan 18, 2024

/cc @gparvin

@openshift-ci openshift-ci bot requested a review from gparvin January 18, 2024 16:14
Copy link
Member

@gparvin gparvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping things up to date. This looks good to me.

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3c330eb into open-cluster-management-io:main Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants